switched from Mock to MagicMock

This commit is contained in:
Lucas Jensen
2024-05-03 18:25:10 -07:00
parent e2b3978fec
commit 65e962e648
4 changed files with 12 additions and 12 deletions

View File

@@ -1,5 +1,5 @@
from datetime import datetime from datetime import datetime
from unittest.mock import Mock from unittest.mock import MagicMock
import pytest import pytest
from icecream import ic from icecream import ic
@@ -8,7 +8,7 @@ from pydantic_core import Url
from app.controllers.events import EventController from app.controllers.events import EventController
from app.models.event import Event, EventSeries from app.models.event import Event, EventSeries
mock_queries = Mock() mock_queries = MagicMock()
ec = EventController(event_queries=mock_queries) ec = EventController(event_queries=mock_queries)
eventbrite_url = "https://www.eventbrite.com/e/the-grapefruits-duo-presents-works-for-horn-and-piano-tickets-1234567890" eventbrite_url = "https://www.eventbrite.com/e/the-grapefruits-duo-presents-works-for-horn-and-piano-tickets-1234567890"
@@ -182,7 +182,7 @@ def test_all_series_with_many_series():
def test_all_series_with_error(): def test_all_series_with_error():
"""Tests an error during the retrieval process.""" """Tests an error during the retrieval process."""
mock_log_error = Mock() mock_log_error = MagicMock()
ec.log_error = mock_log_error ec.log_error = mock_log_error
def invalid_series() -> list[dict]: def invalid_series() -> list[dict]:
@@ -198,7 +198,7 @@ def test_all_series_with_error():
mock_queries.select_all_series = invalid_series mock_queries.select_all_series = invalid_series
with pytest.raises(Exception): with pytest.raises(Exception):
ec.get_all_series() ec.get_all_series()
Mock.assert_called_once(mock_log_error) MagicMock.assert_called_once(mock_log_error)
def test_one_series(): def test_one_series():

View File

@@ -1,4 +1,4 @@
from unittest.mock import Mock from unittest.mock import MagicMock
import pytest import pytest
from fastapi import HTTPException, status from fastapi import HTTPException, status
@@ -7,7 +7,7 @@ from icecream import ic
from app.controllers.group import GroupController from app.controllers.group import GroupController
from app.models.group import Group from app.models.group import Group
mock_queries = Mock() mock_queries = MagicMock()
gc = GroupController(group_queries=mock_queries) gc = GroupController(group_queries=mock_queries)
valid_group_data = { valid_group_data = {
@@ -51,9 +51,9 @@ def test_update_group_bio():
method in the queries module is called with the correct arguments. method in the queries module is called with the correct arguments.
""" """
new_bio = "New Bio" new_bio = "New Bio"
mock_queries.update_group_bio = Mock() mock_queries.update_group_bio = MagicMock()
mock_queries.select_one_by_id.return_value = valid_group_data mock_queries.select_one_by_id.return_value = valid_group_data
group = gc.update_group_bio(new_bio) group = gc.update_group_bio(new_bio)
Mock.assert_called_once_with(mock_queries.update_group_bio, new_bio) MagicMock.assert_called_once_with(mock_queries.update_group_bio, new_bio)
assert isinstance(group, Group) assert isinstance(group, Group)

View File

@@ -1,4 +1,4 @@
from unittest.mock import Mock from unittest.mock import MagicMock
import pytest import pytest
from fastapi import HTTPException, UploadFile, status from fastapi import HTTPException, UploadFile, status
@@ -7,7 +7,7 @@ from icecream import ic
from app.controllers.musicians import MusicianController from app.controllers.musicians import MusicianController
from app.models.musician import Musician from app.models.musician import Musician
mock_queries = Mock() mock_queries = MagicMock()
mc = MusicianController(musician_queries=mock_queries) mc = MusicianController(musician_queries=mock_queries)
sample_data = [ sample_data = [

View File

@@ -1,4 +1,4 @@
from unittest.mock import Mock from unittest.mock import MagicMock
import pytest import pytest
from fastapi import HTTPException, status from fastapi import HTTPException, status
@@ -7,7 +7,7 @@ from icecream import ic
from app.controllers.users import UserController from app.controllers.users import UserController
from app.models.user import User from app.models.user import User
mock_queries = Mock() mock_queries = MagicMock()
uc = UserController(user_queries=mock_queries) uc = UserController(user_queries=mock_queries)
valid_user_data = [ valid_user_data = [